Skip to content

fix Dockerfile #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix Dockerfile #71

wants to merge 1 commit into from

Conversation

yush1ga
Copy link

@yush1ga yush1ga commented Mar 7, 2019

Thanks for making this awesome soft open source.

Unfortunately, Dockerfile doesn't work in my environment.
It may depend on os arch environment.

I tried to fix it by tweaking Dockerfile.

@kylecarbs kylecarbs requested review from nhooyr and removed request for kylecarbs and code-asher March 7, 2019 17:37
@nhooyr
Copy link
Contributor

nhooyr commented Mar 7, 2019

Could you elaborate on the error/issue you were having? I don't see what this fixes.

@code-asher
Copy link
Member

Ah, probably because I added the architecture to the binary name here: 994531d#diff-09fded6ea343c3bb08cac161ed7a3cbaR17

@nhooyr
Copy link
Contributor

nhooyr commented Mar 7, 2019

Dammit Asher. I'll push a fix for this. Thanks for pointing this out @yush1ga

@nhooyr
Copy link
Contributor

nhooyr commented Mar 7, 2019

See #109

@nhooyr nhooyr closed this Mar 7, 2019
@yush1ga
Copy link
Author

yush1ga commented Mar 8, 2019

@nhooyr @coderasher Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr Awaiting requested review from nhooyr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yush1ga @nhooyr @code-asher